I had a question about _actions.c, lines 107 and 111. Will that method of moving through a string work if it's a unicode string instead of a ascii string? (And is that even a concern? I thought we wanted unicode support at least for descriptions, but maybe that won't apply here.) It's probably just a red herring, but I thought I'd at least raise the question.
Also, comments about what the members of the enum stand for would be helpful I think. (WS= white space, QVAL=seen a quote, UQVAL=seen an unquoted val ?) That's all the comments I had. Brock Danek Duvall wrote: > I'm not completely convinced this should be integrated. In trying to fix > > 2686 action key/value pairs separated by tabs cause parsing problems > > I was unable to find a way to make the action parsing with this > functionality go fast in Python. I tried a bunch of different mechanisms, > but they were all significantly slower than the current code, so I > grudgingly implemented it in C. It's marginally faster than the current > code, but has a bit more functionality. I don't know whether it's really > worth the trouble, though it seems like it might be reasonably easy to use > this to implement a reduced-memory-footprint version of the code, something > I haven't actually tried yet. > > Anyway, comments are welcome. > > http://cr.opensolaris.org/~dduvall/pkg-actions/ > > Thanks, > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
