Danek Duvall wrote: > I'm not completely convinced this should be integrated. In trying to fix > > 2686 action key/value pairs separated by tabs cause parsing problems > > I was unable to find a way to make the action parsing with this > functionality go fast in Python. I tried a bunch of different mechanisms, > but they were all significantly slower than the current code, so I > grudgingly implemented it in C. It's marginally faster than the current > code, but has a bit more functionality. I don't know whether it's really > worth the trouble, though it seems like it might be reasonably easy to use > this to implement a reduced-memory-footprint version of the code, something > I haven't actually tried yet. > > Anyway, comments are welcome. > > http://cr.opensolaris.org/~dduvall/pkg-actions/
http://cr.opensolaris.org/~dduvall/pkg-actions/src/tests/api/t_action.py.wdiff.html So is key="" valid? Can you add a test? Otherwise, looks fine to me modulo the concerns Brock raised.. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
