[EMAIL PROTECTED] wrote:
> Folks,
>
> The following webrev contains a number of bugfixes that address the
> handling of I/O errors, detection of truncated network transfers, and a
> series of stack traces to the CLI. There are some neatness fixes
> included for good measure.
>
> http://cr.opensolaris.org/~johansen/webrev-551/
.hgignore:
This seems to be bug 4077 which Comay has just putback recently.
filelist.py:
line 509: s/. Decompress/. Decompress/
lines 528, 542: suggestion: s/should be/expected/
misc.py:
line 517: a docstring would be nice
line 551: two periods ("%s. %s.")? really?
retrieve.py:
line 127-149: I'm not sure I'm keen on code being aware of updatelog
being in retrieve. My inclination is to only have network retrieval
code in retrieve.py; but I'm not deadset on this.
updatelog.py:
line 272: given line 276 is this still right?
Otherwise, seems fine.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
