On Tue, Oct 21, 2008 at 05:52:57PM -0700, [EMAIL PROTECTED] wrote:

> > Catalog.py
> > 541: wouldn't it be an error if size > content_size as well? Or does 
> > that fall into the category of the server sometimes handing back more 
> > than we asked for, which is ok?
> 
> Good catch.  This should probably be a size != content_size.  I'm
> assuming you also intended for this comment to address updatelog.py:321
> and retrieve.py:387?

I noticed this as well, but assumed that getting more data than we were
told we'd get wouldn't really be a TruncatedTransfer, as it were.

Indeed, I suppose it's possible that a catalog could be written to after
the size calculation is done?  We don't do that for any of our production
servers, of course, so it won't be an issue in practice, but there may need
to be some locking in that area.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to