[EMAIL PROTECTED] wrote: >> retrieve.py: >> line 127-149: I'm not sure I'm keen on code being aware of updatelog >> being in retrieve. My inclination is to only have network retrieval >> code in retrieve.py; but I'm not deadset on this. > > What alternative are you proposing? The retrieve code is > client-specific, so we're not breaking any boundaries between the client > and server. Given that the exception handling code between filelist, > catalog, manifest, and datastream are all very similar, it seemed > sensible to start centralizing the routines there, at least for now. > This is all going to change once we re-write the transport stuff.
Don't worry about it then; just a gut feeling... >> updatelog.py: >> line 272: given line 276 is this still right? > > 276 is just skipping lines where we don't recognize the format. The > content-length header should report the size of the entire message. If > we don't include the size of skipped lines in the total, there's a > slight possibility of a mismatch at the end. I thought so, but I wanted to be certain. Thanks, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
