Tom Mueller (pkg-discuss) wrote: > Any comments on this one? > Thanks. > Tom > > Tom Mueller (pkg-discuss) wrote: >> This is a code review request for some problem with building and >> testing the gate on Windows. >> >> Webrev: http://cr.opensolaris.org/~tmueller/cr-3956/ >> Link to issue: http://defect.opensolaris.org/bz/show_bug.cgi?id=3956 >> >> The change to setup.py is to build the _action file on all platforms. >> >> The os_windows.py change is a result of the API changes (change to >> Image.find_root exception).
setup.py: lines 478-484: should be indented by 4 space intervals, not 8 line 485: leading whitespace should be dropped Otherwise, looks fine. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
