Shawn Walker wrote: > > setup.py: > lines 478-484: should be indented by 4 space intervals, not 8 > > line 485: leading whitespace should be dropped I was following the pattern established at lines 519 and 534. I was under the impression that it was more important to make the formatting consistent within a file (even if wrong) than to start following the conventions for just one change. An overall reformatting of setup.py would be a different changeset.
From PEP8: "Consistency with this style guide is important. Consistency within a project is more important. Consistency within one module or function is most important." If you are willing to review a more massive change to setup.py, I'd be glad to reformat the whole thing. Thanks for the review. Tom > > Otherwise, looks fine. > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
