On Tue, Oct 21, 2008 at 01:40:41PM -0700, Brad Hall wrote:
> Link to webrev: http://cr.opensolaris.org/~bhall/bug-3961/
pkg5unittest.py:
- line 160: This one seems a bit weird. Presumably it's one of the
"reduce dependence on unittest.TestSuite" changes, but it still relies
on self.testsRun being defined by unittest.TestSuite, so I'm not sure
how it helps. Indeed, it's not clear to me what reducing dependence on
unittest.TestSuite actually buys us in general.
run.py:
- line 208: I'd strike "Make sure we".
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
