On Thu, Oct 23, 2008 at 04:49:25PM -0700, Danek Duvall wrote: > On Tue, Oct 21, 2008 at 01:40:41PM -0700, Brad Hall wrote: > > > Link to webrev: http://cr.opensolaris.org/~bhall/bug-3961/ > > pkg5unittest.py: > > - line 160: This one seems a bit weird. Presumably it's one of the > "reduce dependence on unittest.TestSuite" changes, but it still relies > on self.testsRun being defined by unittest.TestSuite, so I'm not sure > how it helps. Indeed, it's not clear to me what reducing dependence on > unittest.TestSuite actually buys us in general.
Good point, we can just make our own testsrun variable. The only thing it buys us is the time it takes to go look at what some unittest.class.call() function does when it turns out to be just one or two lines anyhow. > run.py: > > - line 208: I'd strike "Make sure we". OK, removed. Will update the webrev in place shortly. Thanks for reviewing. -Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
