Brock Pytlik wrote:
> Hi, here's my first shot at fixing 2717 to make it easier to deploy new 
> depos.
> 
> I don't have much experience with ksh scripting (you're looking at my 
> first venture) so I'm sure there are lots things I should do differently.
> 
> Webrev:
> http://cr.opensolaris.org/~bpytlik/ips-2717-v1/
> 
> Bug:
> http://defect.opensolaris.org/bz/show_bug.cgi?id=2717
> pkg.depotd: need smf support for depot mode options

pkg-server:
   line 1:  i'm pretty sure this should never be just /bin/sh or 
/sbin/sh since that doesn't really tell us which shell this is (for 
certain) since it is specific to ksh?

pkg-server.xml:
   refresh-index seem odd to me to have as a property given that it is a 
one-time use option which means that the depot is going to exit right 
after starting

Also, you need to update src/man/pkg.depotd.1m.txt to reflect your 
property additions and default value changes.

Otherwise, looks correct.

Cheers,
-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to