On Tue, Oct 28, 2008 at 02:34:32PM -0700, Brock Pytlik wrote: > Hi, here's my first shot at fixing 2717 to make it easier to deploy new > depos. > > I don't have much experience with ksh scripting (you're looking at my > first venture) so I'm sure there are lots things I should do differently. > > Webrev: > http://cr.opensolaris.org/~bpytlik/ips-2717-v1/ > > Bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=2717 > pkg.depotd: need smf support for depot mode options
A few comments: src/pkg-server: - I think you want to add a line like this before the code starts: . /lib/svc/share/smf_include.sh So that things like SMF_EXIT_ERR_NOSMF are defined. - At the end instead of exit 0 maybe exit $SMF_EXIT_OK (not sure what error code to use for the exit 1 case, though). - Missing a stop case; do we need one of those? Aside from that it looks good :) -Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
