On Tue, Oct 28, 2008 at 05:49:29PM -0700, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-2717-v2/
All nits:
pkg.depotd.1m.txt:
- line 109, 115: I'd suggest "Overrides ... and sets it to be true".
Though I think all this "overrides" stuff is confusing, because when
run from the commandline, it doesn't override anything at all, as it
never pulls that information from the SMF. Not this wad.
pkg-server:
- could you name this "svc-pkg-depot".
- You've got one test that uses single brackets and should use doubles.
- And you're using backticks in some places where you should be using $()
instead.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
