On Thu, Oct 30, 2008 at 04:45:47PM -0700, [EMAIL PROTECTED] wrote:
> Looks good.
>
> -j
>
> On Thu, Oct 30, 2008 at 04:42:21PM -0700, Danek Duvall wrote:
> > http://cr.opensolaris.org/~dduvall/pkg-elfcore/
> >
> > Thx,
> > Danek
A follow-up thought: would it make any more sense to eliminate the goto
on line 283, move the err: case under line 294, and then have thread of
execution that is in err goto out instead?
In case my writing was unclear. I was envisioning something like this:
PyDict_SetItemString(pdict, "hash", Py_BuildValue("s", hexhash));
out:
if (dyn != NULL)
dyninfo_free(dyn);
(void) close(fd);
return (pdict);
err:
PyDict_Clear(pdict);
pdict = NULL;
goto out;
Either way works for me, but in this case, we always fall through to the
successful exit case, without having to perform a jump.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
