On Thu, Oct 30, 2008 at 07:18:16PM -0500, Shawn Walker wrote: > Danek Duvall wrote: >> On Thu, Oct 30, 2008 at 06:59:22PM -0500, Shawn Walker wrote: >> >>> elf.c: >>> line 286: This doesn't seem right. Instead of returning pdict if its >>> NULL, shouldn't you perform a Py_DECREF(pdict) and then Py_RETURN_NONE? >> >> Why would I Py_DECREF(pdict)? Its reference count has never been >> increased. > > I was under the (mistaken?) belief that PyDict_New() created pdict with a > reference count of 1, so Py_DECREF would be necessary for early garbage > collection?
Yeah, you're right. I've added that. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
