Danek Duvall wrote: > http://cr.opensolaris.org/~dduvall/pkg-elfcore/
elf.c: line 286: This doesn't seem right. Instead of returning pdict if its NULL, shouldn't you perform a Py_DECREF(pdict) and then Py_RETURN_NONE? I also noticed that the various calls to PyList_New, Py_BuildValue, Py_SetItemString, PyList_Append, etc. don't check the return value for success; in some cases, if they fail, you'll need to do a Py_DECREF. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
