Hi all,
Here's a new webrev for bug #4483
You can find it at:
http://cr.opensolaris.org/~richb/pkg-4483-v2/
After discussing this with David (Comay), the gen_os_file.py script
has been adjusted to automatically create both the opensolaris.org
and the opensolaris.org.sections files from the package classification
data.
Rather than write the new version of opensolaris.org to standard out,
it now automatically writes out the two files to:
../../gui/data/opensolaris.org and
../../gui/data/opensolaris.org.sections
by default, with command line options to allow alternatives.
The new version of the script is now called gen_os_files.py
I also added in debug and help command line options, class'ified it
and added in a CDDL header comment.
Because we are now getting the categories from the actual package
classification information (rather than starting with a full list
of all possible categories), the generated opensolaris.org.sections
file is missing the following:
Category: Applications
Sub-category: Education, Science
Category: Distributions
Sub-category: Server
Category: Drivers
Sub-category: Input devices,Ports
Category: Web Services
Sub-category: Business Applications,Identity,Portals,SOA,Social
Applications
because there are currently no packages that are so classified.
Is this what we want here, or should we start from a fixed list?
Doing this also found the following problems:
1/ Various files:
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-de
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-es
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-fr
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-it
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-ja
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-ko
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-ptBR
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-ru
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-sv
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-zhCN
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-zhHK
.../src/util/distro-import/00/common/loc/SUNWtgnome-l10n-ui-zhTW
.../src/util/distro-import/75a/common/SUNWtgnome-tsoljdsselmgr
.../src/util/distro-import/75a/common/SUNWtgnome-tsoljdslabel
.../src/util/distro-import/75a/common/SUNWtgnome-xagent
.../src/util/distro-import/75a/common/SUNWtgnome-tsol-libs
.../src/util/distro-import/75a/common/SUNWtgnome-tsoljdsdevmgr
.../src/util/distro-import/75a/common/SUNWtgnome-tstripe
should have had a classification of "Desktop (GNOME)/Trusted Extensions"
rather than "Desktop (GNOME)/Trusted".
2/ The classification for:
./99/common/SUNWmeld
should have been "Applications/System Utilities" rather than
"Applications/System U".
3/ All packages in "opensolaris.org" that should have been of
classification "System/X11 (System)" were previously written
as "System/X11".
The new webrev includes those fixups.
Thanks.
-------- Original Message --------
Subject: Code review request for opensolaris packaging bug #4483.
Date: Tue, 04 Nov 2008 08:56:27 -0800
From: Rich Burridge <[EMAIL PROTECTED]>
To: pkg discuss <[email protected]>
Hi all,
I'm looking for a review of the fix for bug #4483:
http://defect.opensolaris.org/bz/show_bug.cgi?id=4483
Need to create the GUI Package Manager opensolaris.org
file from the existing package classifications.
Webrev is at:
http://cr.opensolaris.org/~richb/pkg-4483-v1/
The problem is that the GUI Package Manager currently uses its
own data file of package classifications for the pkg.opensolaris.org
repository (/usr/share/package-manager/data/opensolaris.org), rather
than the package classifications provided as meta-data in the package
manifests.
That means that we currently need to keep this in sync with all the
new packages as they are added to the repo, and with any changes in
package classification.
The new .../src/util/distro-import/gen_os_file.py script does that.
It will read all the package classifications out of the
.../src/util/distro-import/<NN>[common,sparc,i386]<package_name>
files and use them to construct the opensolaris.org file. If more
than one is found, it uses the one from the latest build.
I've also added a .../src/util/distro-import/Makefile target called
guiclassification:. Note that this is not automatically hooked up
to any of the targets that build a distribution, but would need to
be run as a separate command:
$ cd .../gate/src/util/distro-import
$ make guiclassification
This will automatically update the opensolaris.org data file in the
pkg workspace at ../../gui/data/opensolaris.org.
Note also that this is (hopefully) just a stop-gap for the
OpenSolaris 2008.11 release. It is expected that the GUI Package
Manager team will adjust their code to get the package classifications
out of the package manifests (rather than keeping their own separate
data file), for the next OpenSolaris release.
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
