On Thu, Nov 06, 2008 at 02:51:38PM -0800, Rich Burridge wrote: > Danek Duvall wrote: >> You've already put back a fix for bug 4483. This needs to be a new bug. > > Really? You can't commit two changes via the same bug?
Oh, yes, definitely. > I've been doing it wrong for so many years. :-) Then you haven't been working with ON or ex-ON people. :) > Okay. I've open bug #4592 for this: > http://defect.opensolaris.org/bz/show_bug.cgi?id=4592 Thanks. >> I thought we got rid of the duplicate "System" on purpose. > > Don't forget this is "going the other way". I.e. we are now generating > the files that the GUI Package Manager needs, and those still need > to have some category values in brackets as part of the sub-category > value, because it can't handle two sub-categories with the same name > in two different categories. Okay. >> - line 328: This strikes me as being a bit dangerous -- it's going to >> pick up a lot of files that aren't import files, > > Yes but hopefully it handles them correctly and ignores the ones > that are inappropriate. Hopefully. Hm. If you're confident it's not going to pull stuff out of random files, and that it's going to go away really really soon, then great. Otherwise, it'll need to be fixed to do something saner. Danek > http://cr.opensolaris.org/~richb/pkg-4592-v1/ - line 98: Shouldn't this simply be tokens[0]? Likewise on 99, tokens[1]? Or just "category, sub_category = tokens"? Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
