Danek Duvall wrote: > On Thu, Nov 06, 2008 at 02:51:38PM -0800, Rich Burridge wrote: > >> Danek Duvall wrote: >>> You've already put back a fix for bug 4483. This needs to be a new bug. >> Really? You can't commit two changes via the same bug? > > Oh, yes, definitely. > >> I've been doing it wrong for so many years. :-) > > Then you haven't been working with ON or ex-ON people. :)
Ah, then it's an ON bug philosophy vs GNOME or Mozilla. Fair enough. >>> - line 328: This strikes me as being a bit dangerous -- it's going to >>> pick up a lot of files that aren't import files, >> Yes but hopefully it handles them correctly and ignores the ones >> that are inappropriate. > > Hopefully. Hm. If you're confident it's not going to pull stuff out of > random files, and that it's going to go away really really soon, then > great. Otherwise, it'll need to be fixed to do something saner. Understood. I think it's safe and sound. >> http://cr.opensolaris.org/~richb/pkg-4592-v1/ > > - line 98: Shouldn't this simply be tokens[0]? Likewise on 99, tokens[1]? > Or just "category, sub_category = tokens"? No, because it needs to remove the initial and trailing double quotes (which should be present on all classification lines because of the previous classification work I did): $ python Python 2.4.4 (#1, Oct 6 2008, 16:58:10) [C] on sunos5 Type "help", "copyright", "credits" or "license" for more information. >>> line='classification "System/Hardware"' >>> print line classification "System/Hardware" >>> tokens = line.split(None, 1)[1].split("/") >>> print tokens ['"System', 'Hardware"'] _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
