On Fri, Nov 07, 2008 at 06:54:32PM -0800, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-2393-v1/
What about the GUI (for this and the other perms bugs)?
client.py:
- what about adding and removing mirrors? I see the test code for this,
but those calls don't seem to be wrapped here.
imageconfig.py:
- I think this applies to all the non-action permissions problems, but we
don't really want to expose the filenames we're operating on, as
they're generally private interfaces. If this is complicated for some
reason, we can leave it as is for now, and look at it later.
t_pkg_authority.py:
- line 167: no spaces around equals.
- line 173: won't this always succeed because the grep will find mtest?
- line 174: since you already have mtest as the primary authority, can't
you just remove test1 to test this?
- line 179: please wrap
- line 180: shouldn't "test.com" be part of bogus_url?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
