On Mon, Nov 10, 2008 at 05:59:20PM -0800, Brock Pytlik wrote: >> What about the GUI (for this and the other perms bugs)? >> > Not sure what you mean. The GUI behavior is that it will not allow you to > do anything at all (all buttons are disabled) if you're not running with > pfexec.
Ah, okay. >> client.py: >> >> - what about adding and removing mirrors? I see the test code for this, >> but those calls don't seem to be wrapped here. >> > That's an interesting point. I'm definitely testing adding the mirrors, but > I think it's possible it never reaches the mirroring code. The added tests > do pass, but I'll wrap the calls here anyway in case we change the ordering > in the future. I don't follow. How can you definitely be testing adding mirrors without ever reaching the mirroring code? >> t_pkg_authority.py: >> >> - line 174: since you already have mtest as the primary authority, can't >> you just remove test1 to test this? >> > Sorry, totally lost on this one. Did you maybe mean a different line > number? You create the image with the authority name "mtest" (line 166/167). Then you add a second authority called "test1" on line 169. Then you add a third authority called "test2" on line 174. It appears that what you're testing is the ability to unset an authority, but I can't figure out why you're creating "test2". You can already remove "test1" because it's not the primary authority "mtest" is, so you don't need to create "test2" as primary just to remove "test1". >> - line 180: shouldn't "test.com" be part of bogus_url? >> > Actually, it shouldn't be there at all. > Pulled There are a handful of others in other tests, too -- might as well clean them all up? Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
