Danek Duvall wrote: > On Fri, Nov 07, 2008 at 06:54:32PM -0800, Brock Pytlik wrote: > > >> http://cr.opensolaris.org/~bpytlik/ips-2393-v1/ >> > > What about the GUI (for this and the other perms bugs)? > Not sure what you mean. The GUI behavior is that it will not allow you to do anything at all (all buttons are disabled) if you're not running with pfexec. > client.py: > > - what about adding and removing mirrors? I see the test code for this, > but those calls don't seem to be wrapped here. > That's an interesting point. I'm definitely testing adding the mirrors, but I think it's possible it never reaches the mirroring code. The added tests do pass, but I'll wrap the calls here anyway in case we change the ordering in the future. > imageconfig.py: > > - I think this applies to all the non-action permissions problems, but we > don't really want to expose the filenames we're operating on, as > they're generally private interfaces. If this is complicated for some > reason, we can leave it as is for now, and look at it later. > My preference would be to leave it (and the similar other information for the other perm bugs) in place for now. Because we're no longer stack tracing, I can imagine times when knowing which file had the busted permissions actually was important to figure out how to debug. Once we have the debug log or whatever that thing ends up being called, I'm happy to move it there, but for now I'd rather leave it in. > t_pkg_authority.py: > > - line 167: no spaces around equals. > > Fixed > - line 173: won't this always succeed because the grep will find mtest? > You're right, I've changed the name of the test auth. > - line 174: since you already have mtest as the primary authority, can't > you just remove test1 to test this? > Sorry, totally lost on this one. Did you maybe mean a different line number? > - line 179: please wrap > Sorry, fixed. > - line 180: shouldn't "test.com" be part of bogus_url? > Actually, it shouldn't be there at all. Pulled > Danek >
Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
