On Wed, Nov 12, 2008 at 07:41:28PM -0800, Bart Smaalders wrote:
> 4964 dueling chattrs causes one of of them to lose
>
> http://cr.opensolaris.org/~barts/netbeans/
solaris.py:
- line 278: I'm not sure I see the point of these two tests. What
happens if you have two chattrs, the first one changes an attribute of
the original to something different, then the second one comes in and
changes it to the original. With this test, the second chattr would be
ignored, but I can't see why you'd want to ignore it more than you'd
want to ignore any other chattr.
I'd suggest just saying f.changed_attrs.update(a.attrs), but there you
don't get a chance to spit out any warnings.
Same comment goes for the identical code in the other hunk, obviously.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
