On Wed, Nov 12, 2008 at 09:02:43PM -0800, Bart Smaalders wrote: >> - line 278: I'm not sure I see the point of these two tests. What >> happens if you have two chattrs, the first one changes an attribute >> of the original to something different, then the second one comes in >> and changes it to the original. With this test, the second chattr >> would be ignored, but I can't see why you'd want to ignore it more >> than you'd want to ignore any other chattr. >> > > The purpose of these two tests are accumulate only changes from each > chattr* in f.changed_attributes... since each chattr is (confusingly) > applied to the original file specification, unless we note which portions > are changed by each chattr, subsequent changes by other > chattrs will undo our previous modifications.
I thought we already were potentially overwriting previous chattrs -- that's what the test on line 280 indicates. Can you give an example? > The test on line 280 is there at David's request, since fighting > chattrs can be indications of problematic behavior. Absolutely. That one I get. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
