Danek Duvall wrote: > On Wed, Nov 12, 2008 at 07:41:28PM -0800, Bart Smaalders wrote: > >> 4964 dueling chattrs causes one of of them to lose >> >> http://cr.opensolaris.org/~barts/netbeans/ > > solaris.py: > > - line 278: I'm not sure I see the point of these two tests. What > happens if you have two chattrs, the first one changes an attribute of > the original to something different, then the second one comes in and > changes it to the original. With this test, the second chattr would be > ignored, but I can't see why you'd want to ignore it more than you'd > want to ignore any other chattr. >
The purpose of these two tests are accumulate only changes from each chattr* in f.changed_attributes... since each chattr is (confusingly) applied to the original file specification, unless we note which portions are changed by each chattr, subsequent changes by other chattrs will undo our previous modifications. The test on line 280 is there at David's request, since fighting chattrs can be indications of problematic behavior. - Bart -- Bart Smaalders Solaris Kernel Performance [EMAIL PROTECTED] http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
