> > > Intuitively, I agree. However, we have some assumptions in our test > > > suite that if an authority is disabled, we remove its catalog entries > > > unless a refresh is not allowed. In that case, we leave the catalog in > > > place until such a time that we can connect to the network and refresh > > > the catalog. I wrote a similar version to what's above, but found it > > > didn't pass test. > > > > > > The other possibility is to change the test case, if we think it's > > > incorrect. > > > > The test seems incorrect to me. If whoever wrote the test can justify it, > > I'm open to being persuaded. Otherwise, please change the test. > > IIRC, Brock wrote the test. If he's fine with a change, I'll modify the > test and update the fix.
I incorrectly blamed Brock for this. We went back and looked at the tests. It's actually an enable/disable case that Tom wrote. Since I'm fixing some of his other bugs in another putback, I'm going to assert editorial license here and fix the testcase. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
