I wrote that test (assuming you are referring to test_enable_disable in
t_pkg_authority.py).
The test does assume that if an authority is disabled, then the entries
for that authority are removed from the catalog for the image. It seems
to me that that should be required, even if the authority cannot be
contacted. We don't want a "pkg list -a" to return entries from a
disabled catalog.
That test doesn't use the --no-refresh option to set-authority, so I
don't understand the "unless a refresh is not allowed" part. We
shouldn't be leaving the catalog in place for a disabled catalog in any
case.
Tom
[email protected] wrote:
Intuitively, I agree. However, we have some assumptions in our test
suite that if an authority is disabled, we remove its catalog entries
unless a refresh is not allowed. In that case, we leave the catalog in
place until such a time that we can connect to the network and refresh
the catalog. I wrote a similar version to what's above, but found it
didn't pass test.
The other possibility is to change the test case, if we think it's
incorrect.
The test seems incorrect to me. If whoever wrote the test can justify it,
I'm open to being persuaded. Otherwise, please change the test.
IIRC, Brock wrote the test. If he's fine with a change, I'll modify the
test and update the fix.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[email protected]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
