Alright. I have a new webrev that should address these issues. It requires a couple of test-suite modifications too.
http://cr.opensolaris.org/~johansen/webrev-6339-2/ -j On Wed, Feb 04, 2009 at 04:02:53PM -0800, Danek Duvall wrote: > On Wed, Feb 04, 2009 at 03:52:18PM -0800, [email protected] wrote: > > > I had that backwards. The delayed refresh case is failing, but it's > > because we change the origin for an authority and specify --no-refresh. > > In the old code, the catalog wouldn't get deleted but a full refresh > > for that authority would occur next time we executed an image-modifying > > operation. Now, the catalog gets deleted, but since we don't refresh > > the test fails, because it looks like the catalog is empty. The > > previous behavior was to let the stale catalog persist until refresh, > > but the current behavior is to remove the catalog as soon as it becomes > > out of date. Either seems correct to me, but we need to pick one. > > If we change the origin for authority and specify --no-refresh, we should > remove its catalog and rebuild the catalog cache, without downloading a new > catalog (and caching it). Please make sure, however, that any packages > already installed from that authority still show up in the catalog cache. > > If the authority is enabled, then the next image-modifying operation should > retrieve its catalog and rebuild the catalog cache. > > If the authority is disabled, then the authority should be ignored until it > is enabled. Enabling the authority should retrieve its catalog and rebuild > the catalog cache. > > Does that cover all the bases? > > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
