Bart Smaalders wrote:
Shawn Walker wrote:
...
webrev:
http://cr.opensolaris.org/~swalker/pkg-2691/
Thanks for doing this!
Some minor nits on a few files (I didn't look at the server changes)
depot.py:
...
file.py: 113, 297, also license.py 115
should we add a function into util to handle computing file
hashes? We're going to want this more abstracted later
when we switch hash functions...
Yes, that's fine. I'll add something to misc and use it there.
Although it's a little tricky as sometimes we compute the hash and want
the returned data, and other times we don't. I need to make it so that
when we don't want the data, it can be immediately discarded to prevent
memory footprint blowout.
solaris.py:
...
Shouldn't the proto area logic be in the makefile? You can
always add another argument to transfer this... also, solaris.py
I see that now; will add a -p option for "proto" to solaris.py and
update Makefile.
really assumes Solaris.... so why is this cross platform?
Because I just lifted it from somewhere else where we do the same thing
without thinking about the fact that we only use the importer on
Solaris. This has all been axed.
Thanks for your feedback,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
