[email protected] wrote:
Hi Shawn,
Sorry it took me longer than Danek to get a review back to you. I had
my eyes dilated yesterday morning. I had a hard time reading email
for the first half of yesterday.
webrev:
http://cr.opensolaris.org/~swalker/pkg-2691/
* the depot server will now only create a repository if not started with
--readonly. See tests/cli/t_pkg_depotd.py:test_repo_create for details.
Would you clarify what you mean by "create a repository." Does this
mean that if we have packages on disk, but no catalog, it will rebuild
the catalog only if it's not --readonly? Or does this mean something
else?
It is only referring to the repository directory, and the directories
within it (pkg, trans, index, etc.). That is what determines whether it
*thinks* it has a valid repository.
actions/__init__.py:
...
* actions now determine the size of the specified data payload if the
pkg.size attribute is not provided
I took a look at generic.__init__(). It appears that the code computes
the size of the payload by either performing a stat(2) or by calling
len(data). Is this code getting run before the file data is being
compressed on the publication side? If not, shouldn't this properly
calculate both size and csize when looking at compressed files?
The code is getting run before the file data is compressed.
server/repository.py:
- lines 48-56: There are a couple of places where this exception is
getting raised. Clients expect a HTTP 304 when the catalog is up to
date. Where in the code do you map the
RepositoryCatalogNoUpdatesError to a HTTP 304? I can't seem to find
it, but that doesn't mean its not there.
Nice catch; fixed.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
