Danek Duvall wrote:
On Wed, Feb 11, 2009 at 03:15:33PM -0600, Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-2691-3/
actions/generic.py:
- line 170: this doesn't catch anything -- it's only for line 150. You
probably want to wrap the entire "try/except AttributeError" bit in an
exception that catches EnvironmentError.
Argh; thanks.
server/config.py:
- line 85: this is unprotected from EnvironmentError. If you don't have
write access to the parent of repo_root, will this have failed
previously? I'd be tempted to roll this directory creation into that
of its subdirectories, either by letting os.makedirs() do the work, or
doing it separately, but in the same loop.
I'll just let os.makedirs() do the work; seems reasonable enough. It
makes the error message a little less specific, but it seems more
efficient and the resulting error will still be understandable.
server/transaction.py:
- line 65: could self.data be really huge here? Or binary?
It's the text of the exception that occurred, not the actual data :-)
I'll putback tomorrow morning.
Thanks to all for the review,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
