>> - If you do need to parse stderr, there are some alternatives to the
>>   current approach.  Popen.communicate() returns a (stdout, stderr)
>>   tuple and waits for the process to terminate.  If the output from
>>   beadm is expected to be small, this would be the way to go.
>>
>>   
> I have regenerated the webrev to use communicate. See 
> http://cr.opensolaris.org/~padraig/ips-6549-v2/.

The lines that you added look fine; however, I'm curious why you removed
the stdout -> /dev/null redirection.  Is stdout already closed in
packagemanager?

Thanks,

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to