Padraig O'Briain wrote:


On 02/23/09 22:04, [email protected] wrote:
I have reworked the webrev, http://cr.opensolaris.org/~padraig/ips-6549-v3/, to remove all calls to beadm.

This looks a lot better.  Just a few more comments:

I have updated the webrev http://cr.opensolaris.org/~padraig/ips-6549-v4/.
- line 529: This looks like an extra return statement

- lines 528, 532: Does the BE code ever raise an exception, or are all
  errors returned in a numerical code?

It looks to me that libbe just returns a numerical code.


You can use "beGetErrDesc()" to map the numerical error codes returned to their corresponding strings.

-evan

Padraig
-j

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to