CCing ethan
jmr wrote:
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-4503-v1/ , fixes
4503 Modify New Boot Environment dialog to allow BE name to be
specified..
This change makes the BE Name text field visible in the dialog that
appears when doing Update All.
The specified BE name is passed to Image.plan_update_all which throws
an exception if the name is not a valid BE name.
Perhaps, we should validate the name ourselves and display an error
message before calling plan_update_all.
We should validate the name in the same way that we do so when adding
a new repo in the Manage Repos dialog. This way the user gets
immediate feedback if the name is already in use and they can take
appropriate action by changing the name.
To be clear, as far as I can tell from my testing, validate_be_name (or
whatever it's called in the libbe library) only checks for syntactic
correctness. It won't detect name collisions until an attempt is made to
create the new BE which fails because of a name collision.
I would like to see us put in a suggested name initially along the
lines of:
Confirm Boot Env Dialog:
- Make sure we put in a default name for the user <current BE>[strip
off ending numeric]<yyyy-mm-dd>(if conflict add :<hr>:<min>)
Talk to the libbe people, they're doing a fair amount of this already
and syncing your efforts up with theirs probably makes sense.
Brock
If the name is already in use the text
"A problem occured while attempting to rename the boot environment
currently named opensolaris-12 to opensolaris"
is added to the dialog which is displayed after the update all has
fixined.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
