I have reworked the webrev to address these issues.
The webrev validates the user input of the BE name in the same way as
the repository name is validated in Manage Repositories dialog.
The webrev does not attempt to set a default BE name.
The new webrev is at http://cr.opensolaris.org/~padraig/ips-6986-v1/
Padraig
On 02/27/09 21:05, Brock Pytlik wrote:
installupdate.py:
373-386: there are other api exceptions that can bubble up from this
code. Not being able to mount the BE for example or being unable to
copy the BE in the first place. It probably makes sense to catch those
at this same spot unless there's a reason not to. api_errors has a
full list of the api_exceptions which can bubble out, just look for
the ones that subclass BEException
From what I remember, being unable to rename the BE means that the
operation has failed before any of the bits got updated. It looks to
me like the code as is tells the user that "everything worked except
the BE doesn't have the right name, but the bits have been updated so
go ahead and reboot." I'm fairly certain this is wrong.
Same comment applies to update manager.
Brock
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-4503-v1/ , fixes
4503 Modify New Boot Environment dialog to allow BE name to be
specified..
This change makes the BE Name text field visible in the dialog that
appears when doing Update All.
The specified BE name is passed to Image.plan_update_all which throws
an exception if the name is not a valid BE name.
Perhaps, we should validate the name ourselves and display an error
message before calling plan_update_all.
If the name is already in use the text
"A problem occured while attempting to rename the boot environment
currently named opensolaris-12 to opensolaris"
is added to the dialog which is displayed after the update all has
fixined.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
