jmr wrote:
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-4503-v1/ , fixes
4503 Modify New Boot Environment dialog to allow BE name to be
specified..
This change makes the BE Name text field visible in the dialog that
appears when doing Update All.
The specified BE name is passed to Image.plan_update_all which throws
an exception if the name is not a valid BE name.
Perhaps, we should validate the name ourselves and display an error
message before calling plan_update_all.
We should validate the name in the same way that we do so when adding a
new repo in the Manage Repos dialog. This way the user gets immediate
feedback if the name is already in use and they can take appropriate
action by changing the name.
I would like to see us put in a suggested name initially along the lines
of:
Confirm Boot Env Dialog:
- Make sure we put in a default name for the user <current BE>[strip off
ending numeric]<yyyy-mm-dd>(if conflict add :<hr>:<min>)
BE names don't normally have the time stamp as part of the name. This
would also make for very cumbersome names if you were to do this. Also
there is already a mechanism for creating auto-generated names in libbe
and if you're wanting an auto-generated name this is what should be used.
As for the suggested name are you thinking some type of default?
If you're going to provide a suggested name you'd want to make sure that
this suggested name doesn't already exist, purhaps by calling beList and
then checking for that BE name or call beList for that BE name and see
if anything is returned. However I really think it may be be better to not
suggest a name and let them choose one on their own.
-evan
If the name is already in use the text
"A problem occured while attempting to rename the boot environment
currently named opensolaris-12 to opensolaris"
is added to the dialog which is displayed after the update all has
fixined.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
