One more small nit, please update the copyright date for updatemanager.py
Thanks,
-evan
Evan Layton wrote:
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-4503-v1/ , fixes
4503 Modify New Boot Environment dialog to allow BE name to be
specified..
This change makes the BE Name text field visible in the dialog that
appears when doing Update All.
The specified BE name is passed to Image.plan_update_all which throws
an exception if the name is not a valid BE name.
Perhaps, we should validate the name ourselves and display an error
message before calling plan_update_all.
Why reinvent this when a call to beVerifyBEName() can be used to
validate the name? Couldn't you call this before plan_update_all?
If the name is already in use the text
"A problem occured while attempting to rename the boot environment
currently named opensolaris-12 to opensolaris"
If you know the problem is a name collision why not tell them that's the
problem by saying something more like "the BE name opensolaris already
exists, the rename of opensolaris-12 to opensolaris failed."?
is added to the dialog which is displayed after the update all has
fixined.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
