Danek Duvall wrote:
http://cr.opensolaris.org/~bpytlik/ips-2670-v4/
pkgdefs/Makefile:
- line 36: let's keep the packages in alphabetical order.
Sorry about that, I intended to. Apparently the concept of a... b....
c... is something I'm still struggling with.
SUNWpython-ply/Makefile:
- line 30: You don't use PROTOLOC anywhere.
It's quite possible it's not necessary. I based my file off the mako
one, which has it. I wasn't certain exactly how everything fits together
in this area. I'll remove it and make sure the packages still build
correctly.
I don't see a change to src/util/distro-import/publish_ips. Did you
determine that wasn't necessary?
In the copyright file, please put the following text at the top:
For the avoidance of doubt, except that if any license choice other
than GPL or LGPL is available it will apply instead, Sun elects to
use only the Lesser General Public License version 2.1 (LGPLv2) at
this time for any software where a choice of LGPL license versions
is made available with the language indicating that LGPLv2.1 or any
later version may be used, or where a choice of which version of the
LGPL is applied is otherwise unspecified.
--------------------------------------------------------------------
Will do.
Otherwise, looks fine.
Thanks for the quick turnaround!
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
