> http://cr.opensolaris.org/~bpytlik/ips-2670-v4/

pkgdefs/Makefile:

  - line 36: let's keep the packages in alphabetical order.

SUNWpython-ply/Makefile:

  - line 30: You don't use PROTOLOC anywhere.

I don't see a change to src/util/distro-import/publish_ips.  Did you
determine that wasn't necessary?

In the copyright file, please put the following text at the top:

    For the avoidance of doubt, except that if any license choice other 
    than GPL or LGPL is available it will apply instead, Sun elects to 
    use only the Lesser General Public License version 2.1 (LGPLv2) at 
    this time for any software where a choice of LGPL license versions 
    is made available with the language indicating that LGPLv2.1 or any 
    later version may be used, or where a choice of which version of the 
    LGPL is applied is otherwise unspecified.

    --------------------------------------------------------------------

Otherwise, looks fine.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to