Could you show the change in output to the user for the
PlanCreationException?
image.py
lines 2304-2305 repeated unknown across line break (I think that's a
typo unless we're talking about known knowns, known unknowns and unknown
unknowns ;) )
2452-2460, 2462-2470: I think these lines could be combined and use the
if to decide which set of names it's working on.
LGTM,
Brock
Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
6856 operations fail if installed package from removed publisher
exists in another publisher's catalog
7456 install and update all should try harder to eliminate multiple
matches
webrev:
http://cr.opensolaris.org/~swalker/pkg-6856/
Change Summary
==============
* changed image.load_catalogs() to add the installed publisher of a
package to the catalog cache
* changed make_install_plan to be more forgiving of multiple matches
when there is a reasonable way to eliminate duplicates
* added unit tests to verify that image-update and install work in the
face of publisher removal or multiple matches
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss