Brock Pytlik wrote:
Could you show the change in output to the user for the PlanCreationException?

No real change; just fixing a visual anomaly. In short, they don't start with "pkg: pkg:" now. That should never be in the exception text anyway as clients other than pkg.1 use the exceptions.

Before
------
# pkg -R / install -nv --no-refresh nosuchpackage
Creating Plan \
pkg: pkg: The following pattern(s) did not match any packages in the current
catalog. Try relaxing the pattern, refreshing and/or examining the catalogs
        nosuchpackage

After
-----
pkg-6856/src$ ./client.py -R / install -nv --no-refresh nosuchpackage
Creating Plan \
pkg: The following pattern(s) did not match any packages in the current catalog.
Try relaxing the pattern, refreshing and/or examining the catalogs:
        nosuchpackage

image.py
...
2452-2460, 2462-2470: I think these lines could be combined and use the if to decide which set of names it's working on.

I'm going to pass on this one as this is what was there before and every alternate solution I've tried so far seems equal in size and less clear given that each case has a different set of conditions.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to