On Tue, Mar 24, 2009 at 12:39:53AM -0500, Shawn Walker wrote:
>> http://cr.opensolaris.org/~swalker/pkg-6856/
Why are you putting the publisher state into the catalog data structure?
Can't inventory() determine that quickly at runtime? Part of the reason
that pkg list is getting slow again is that the pickle is getting huge, and
while we need to fix that, this isn't going to help at all. (That said,
the code for all this looks fine, though I might get rid of publist from
__inventory() entirely, and just use pubstate, with .keys() when
necessary.)
image.py:
- line 2286: Given that state is always passed in as PKG_STATE_INSTALLED,
why not default this argument to it, or eliminate the argument
entirely?
- line 2287: Perhaps I'm not getting enough sleep, but this makes little
sense to me. Could you restructure the comment explaining exactly what
you're filtering out, or filtering in? I'm not sure whether "publisher
is known" means that a package matching this criterion is eliminated
from potential matches, or allowed in the set.
Are any of the tests for these states? All the new tests seem to be
for the publisher removal bits.
- line 2304: "unknown unknown". Unless you're actually Donald Rumsfeld,
please remove one of these "unknown"s. Also "whom" -> "which". And
"that are for" doesn't make much sense here.
- line 2315: How would we get in this state? That is, if the package is
no longer in any publisher's catalog, how would they have ended up in
the list of matches?
- line 2452: Given that we only support one preferred publisher right
now, will the filtering ever do anything?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
