On Tue, Apr 07, 2009 at 05:46:46PM -0700, Dan Price wrote: > On Tue 07 Apr 2009 at 04:48PM, [email protected] wrote: > > Folks, > > > > This morning Shawn and I tracked down a problem with the depot's error > > handling. At some point in the recent past, the catalog stopped > > returning a 304 error when the client requested an incremental update, > > and no further updates were available. > > > > Shawn and I have been going over the fix offline, but I wanted to post > > the webrev here, in case anyone else wants to take a look. > > > > http://cr.opensolaris.org/~johansen/webrev-8010/ > > Any test cases to be written here?
I can think of a straight-forward way to write a standalone test case, but it's less clear to me how to integrate the case with the testsuite. Perhaps you have some suggestions? Essentially, I need to connect to a depot, request a catalog, steal the Last-Modified header, and then re-request a catalog with If-Modified-Since of the new request set to the value of Last-Modified from the previous request. If we get a 304 success, otherwise failure. I was under the impression that the CLI portion of the test suite was for using CLI-based interfaces and the API portion was for calling module functions directly. If we have a way to do this with the test suite already, then I'd be happy to add a test case. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
