On Wed, Apr 08, 2009 at 01:26:18PM -0500, Shawn Walker wrote: > [email protected] wrote: >>>> http://cr.opensolaris.org/~johansen/webrev-8010/ >>> I'm surprised by the change to t_pkg_install to use --full for >>> refresh. Why is that needed? >> >> That particular test case assumed that every refresh would modify >> catalog metadata. In the first place I changed, it expected to fail >> with an error because it didn't have appropriate permissions to change >> the catalog. However, when the catalog is up to date and we receive a >> 304, no modification to the catalog is made. I changed this to --full >> so it would always update the catalog and have it's permissions check >> fail. > > Ah, that makes sense now. > > "Ship it!"
Thanks. I updated the webrev with the changes to the testsuite that you and Dan requested. I'll push after I attach a new diff to the bug report. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
