On Thu, Apr 09, 2009 at 04:36:41PM -0500, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-8072/
api.py:
- So the distinction between catching Exception and a bare except is
what, right now? In case someone raises a string, or other
non-compliant exception? In 2.5 forwards, these will all need to
change to catch Exception and BaseException, respectively?
history.py:
- line 411: it seems weird to tie "error" and multi_value together like
this.
- line 424, 425: why not just extend() op.errors with the result of
get_node_value()?
t_history.py:
- line 378: Any chance this doesn't have to be all on one line? I don't
mind going over 80 characters a bit from time to time, but this is a
bit excessive.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
