On Thu, Apr 09, 2009 at 10:15:51PM -0500, Shawn Walker wrote: >> - So the distinction between catching Exception and a bare except is >> what, right now? In case someone raises a string, or other >> non-compliant exception? In 2.5 forwards, these will all need to >> change to catch Exception and BaseException, respectively? > > Yes, because we still have code in a few places that doesn't raise a proper > exception (uses a string), and because modules that we use may do so and we > have no way of stopping them.
Okay, just checking. > http://cr.opensolaris.org/~swalker/pkg-8072-2/ Looks fine. Only comment is that now get_node_values() doesn't return a non-list value when child_name == None and the exception is raised, so op.start_state and op.end_state could be empty lists instead of None. That's okay, presumably? Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
