Brock Pytlik wrote:
Dan Price wrote:
On Fri 24 Apr 2009 at 02:37PM, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-5247-v1/
Bug:
5247 Test suite should provide timing info
http://defect.opensolaris.org/bz/show_bug.cgi?id=5247
This adds a -t option to the setup.py test command. When it's
present, it produces a timing_info.txt file in the tests directory
which has info for the test suite classes and functions. There's
lots more work that could be done to make it fancier and have it
present nicer output, but for now, it's functional and produces
apparently correct output. So I'd generally like to leave other
functionality requests for future RFEs.
The reason that -t is a flag, and not an option for a file is bug 8397.
Should emitting timings be the default behaviour instead of an
optional one?
I thought about that, and didn't really come to a firm conclusion on
it. It'll overwrite the previous timing file each time it's run with
the -t option (or always if it was the default), which could be
annoying if you're testing a single test for timing and blow away your
data for the entire test suite. Honestly, I figured not many people
other than me would be using this much at the moment (since it seems
like the search suites are responsible for an absurd percentage of the
time taken during the test suite, and fixing that up will probably
mean this won't be an issue again for a while). If the consensus is to
make it the default, that's an easy switch, I'll change the option to
be -T and it'll mean don't do the timing.
Also, I would find it easier to read if you didn't use quite so
many decimal places :) I think 3.55 is more helpful than 3.55107688904.
Ok :)
-dp
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Based on Dan's feedback, I've changed things slightly so that the output
now looks like:
4.70 TestApiSearchBasics
16.90 TestPkgSearchBasics
============================================================
4.70 TestApiSearchBasics test_local_0
16.90 TestPkgSearchBasics test_local_0
============================================================
============================================================
With the seconds first, and the rest of the info second. Since it's
fixed width, I think that works better for now.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
