Danek Duvall wrote:
On Fri, Apr 24, 2009 at 02:37:16PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-5247-v1/
setup.py:
- line 575: "stoed" -> "stored"
pkg5unittest.py:
- line 218: do we still need this older timing code?
Yep, that's giving you the total time for the entire test suite (the
"Ran X tests in Y seconds" output after the test suite). I think that's
still useful and would like to retain it.
- line 225: would
for (cname, mname), secs in t.timing.items():
work?
Yep.
- line 270: make "stream" the first argument.
Sure, why?
- line 294: I think just do "if hasattr(self, "timing")". But why is
this necessary at all?
Was a relic from when I was confused about who was instantiating what
when, is now replaced with self.timing = {}
- line 307, 349: where is this used?
It's relic code, consider it removed.
Danek
Thanks for taking a look,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
