On Fri, Apr 24, 2009 at 04:00:02PM -0700, Brock Pytlik wrote: > Danek Duvall wrote: >> On Fri, Apr 24, 2009 at 02:37:16PM -0700, Brock Pytlik wrote: >> >>> http://cr.opensolaris.org/~bpytlik/ips-5247-v1/ >>> >> pkg5unittest.py: >> >> - line 218: do we still need this older timing code? >> > Yep, that's giving you the total time for the entire test suite (the "Ran X > tests in Y seconds" output after the test suite). I think that's still > useful and would like to retain it.
Okay. I wasn't sure if it could be replaced with sum(timing.values()) or something. >> - line 270: make "stream" the first argument. >> > Sure, why? More natural -- like fprintf(). Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
