Shawn Walker wrote:
Brock Pytlik wrote:
This webrev gives additional savings for the time to run the test
suite. It drops the total running time by about 140 seconds on my
machine.
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-8534-v1/
Bug:
8534 pkgsend should optionally send packages in persistent depot tests
http://defect.opensolaris.org/bz/show_bug.cgi?id=8534
I'm concerned that changing everything to run an api install means
that we won't sufficiently test the cli.
In particular, it doesn't feel right to change t_pkg_install to use
the api rather than the pkg cli.
Maybe we need a t_pkg_api_install and a t_pkg_install?
Cheers,
I think the right approach is to have a small set of test cases which
exercise the command line options to make sure they're parsed correctly,
and compare the output of those tests to what's expected to check that
the command is displaying the right things. Other than that, I think
everything should be moved to using the api where possible due to the
speedup it provides (and the more exact error reporting and checking it
allows). Looking at the tests I changed in t_pkg_install, I don't see
any place really where we're testing the command line parsing nor where
we're checking the output of the commands.
t_pkg_install contains some tests to explicitly check command line
parsing and other test suites still use self.pkg("install")
One of the mistakes I made (from a runtime/headache point of view) was
doing the initial split of t_api_search and t_pkg_search. I did it
because I wanted to make sure that the api install stuff worked just
like running it from the command line. When I did the putback of 7314,
which consolidated most or all of the duplication between the test
suites, that was the end of that experiment for me.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
