Brock Pytlik wrote:
Well, what I did (or tried to do? or meant to do?) with the search suites was to leave tests which checked failure modes, ie, which checked what happened when an expected exception was propagated out to the client code. (See tests for 8098, 7835, and others in t_pkg_search). Unless I made a mistake in my change of the test suite, none of the places where I shifted to api calls should throw an exception, so they weren't testing an exception escaping to the surface anyway. So I'm still not understanding the concern here regarding my conversion. If you're saying we need more tests to exercise specific exception paths, I'm certainly not arguing that, but that's not this bug, and isn't this wad's job to fix.
Sorry, I didn't mean to confuse matters further. As I said, what you have here is fine. I just have a general concern about moving much of the test suite to use the api instead of the cli, since I'm not yet confident of the testing paths for the cli.
Long-term, we probably need to form a bit more comprehensive approach so that new unit tests, etc. fit with the work you've done here and don't leave the cli with inadequate execution path testing.
Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
